The option "Show Webmin switch in navigation menu for server owners" keeps reverting to "No"

Subj. You have to set it to "Yes" couple times to see it is finally set, but then if you go to Virtualmin configuration after some time it is back to "No".

Status: 
Closed (fixed)

Comments

I am not sure if there are other reasons, but I've just saved a template, went back to Virtualmin configuration page and it was back to No.

Joe's picture
Submitted by Joe on Mon, 10/15/2018 - 21:15 Pro Licensee

Where are you seeing that option? I can't find any language file with "Show Host Manager" in it in the Virtualmin or Authentic theme repos, so I can't figure out how to test this (or what code is driving it).

Title: The option "Show Host Manager switch in navigation menu for server owners" keeps reverting to "No" » The option "Show Webmin switch in navigation menu for server owners" keeps reverting to "No"

Sorry it was our custom translation, it's actually Webmin tab.

Ilia's picture
Submitted by Ilia on Tue, 10/16/2018 - 09:40

if you go to Virtualmin configuration after some time it is back to "No". @yngens It has been moved away from Virtualmin Configuration. You will no longer see it there but from now on, it will be placed in Administration Options/Edit Owner Limits/Other restrictions

Joe's picture
Submitted by Joe on Tue, 10/16/2018 - 15:37 Pro Licensee

Status:
Active
»
Fixed (pending)

I'm gonna mark this one fixed (pending), as it's fixed in git, so the next release of Webmin that has a theme update will fix it. The old option is apparently buggy (which, I think compounded the confusion caused by the difference of opinion about what the option was supposed to mean).

Jamie has rolled 1.894 devel version, so I'll roll it out today to all repos. I'm not sure which version of the theme it's shipping with...if it doesn't include this fix, we'll do another stable Webmin release pretty soon to address it.

Thanks for the inputs. I got it now, but still wonder will there be any global setting for this option or, if not, then what will be the default option? Hopefully, Webmin tab will be there by default.

Also how exactly I could update to git version to start testing the new feature?

Ilia's picture
Submitted by Ilia on Wed, 10/17/2018 - 06:39

I confirm that option works but it don't stick in UI. I will have to fix that.

To test it you would have to update Webmin to latest version using ./update-from-repo.sh. This script also updates the theme.

It should be okay, but there is a risk of things going wrong, so I wouldn't tested it on production machine unless you know what you're doing.

Just tested this and confirm it finally works as expected. Thanks Ilia!

Status:
Fixed (pending)
»
Active

Ilia, unfortunately even with the version downloaded using ./update-from-repo.sh the setting keeps reverting back to No. To replicate set it to Yes, then go to and save any Plan, go back and check the setting and you will see it is back to No.

And just you have all the information, here is the environment where the field fails to hold the set value and consistently reverts back to No after you save something on Virtualmin:

Operating system CentOS Linux 7.5.1804
Webmin version 1.894.1017.0250 
Usermin version 1.741
Virtualmin version 6.04 
Theme version Authentic Theme 19.19
Ilia's picture
Submitted by Ilia on Sun, 10/21/2018 - 05:28

Okay, latest commit fixes related and other issues with storing theme config on the fly.

Ilia's picture
Submitted by Ilia on Sun, 10/21/2018 - 05:29

Status: Active » Fixed (pending)

So how do I test the latest commit? Do I run ./update-from-repo.sh again? Or should I just pull the Authentic Theme separately?

I did upgrade to Authentic Theme 19.20-beta6 and could not find the "Show Webmin switch in navigation menu for server owners" at tis usual place. Was removing the option intentional?

Anyway, the Webmin for end-users (website owners) finally work consistently and I believe the beta-version should go production as soon as possible, because it is really not nice to leave users without Webmin tab. Missing Webmin tab is actually pretty serious bug, because lot's of our users rely and number of features under that tab. So Jamie and Ilia, when you think this bug will be addressed in the production versions of both software? Please push this fix to production version ASAP.

Ilia's picture
Submitted by Ilia on Tue, 10/23/2018 - 16:57

Expected time upcoming weekend. We have few things to be finished before it's done.

I'm planning to release final theme version 19.20 by Saturday 6pm (Moscow time), Saturday morning for Jamie.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.