Backup All Virtual Servers & Limit to Servers on Plan = No domains selected to backup

Submitted by Reidtech on Mon, 12/11/2017 - 12:10

Pretty much as the title says.

Environment:
Operating system CentOS Linux 7.4.1708
Webmin version 1.870
Usermin version 1.720
Virtualmin version 6.02
Theme version Authentic Theme 19.04

Steps to reproduce:
- Create a scheduled backup
- Servers to save: All virtual servers
- Limit to servers on plan: Selected plans .. (select some)
- Backup all features
- Backup destinations: Local file or directory (/backup/virtualmin/weekly/%Y-%m-%d) (also see XKCD about ISO 8601)
- Delete old backups Yes, after 7 days
- Additional destination options Do strftime-style time substitutions on file or directory name
- Backup format One file per server
- Create destination directory
- Action on error Continue, but don't purge old backups
- Backup level Full (all files)
- Scheduled backup time Complex schedule Every Monday at 1:05
- Save/Create it

Then from the Scheduled backups list, click Backup (this takes you to Backup Virtual Servers) with the form values prepopulated.

Click Backup Now

Observe the result:

Error
Backup failed : No domains selected to backup

It would be really nice to be able to backup by plan, if I have to edit scheduled backups to add virtual servers as they are created without just being able to backup by plan that is going to be a bit of a maintenance nightmare.

Am I missing something?

Anyone else getting this?

Status: 
Closed (fixed)

Comments

Submitted by Reidtech on Mon, 12/11/2017 - 12:16

Seems this bug report system has an issue with newlines. I will try and edit the report to make it more readable but it appears that <br> is not included in the text formats....

edit: actually, though not documented, it appears it will accept and render br tags. Report should be more readable now.

Submitted by Reidtech on Mon, 12/11/2017 - 12:29

I tried toggling it to selected servers, selecting them all, then toggling back to all servers, then selecting a plan that only one server is on, and it backed up all the servers.

So I'm gonna call that broken. :(

Any hints on where to look in the code to fix it myself?

Submitted by JamieCameron on Mon, 12/11/2017 - 21:52

Ok, I see the cause of this - it will be fixed in the next Virtualmin release. Looks like it only happens when multiple plans are selected.

Submitted by Reidtech on Tue, 12/12/2017 - 07:51

Coolness. Thanks!

(P.S. it seems the schedule ran as intended... almost, I had set one schedule (daily) to use only one plan, when I looked at it today it had run, but the schedule was now set to backup all plans (none selected) - not sure if I jsut did not save it properly yesterday or whether it modified the schedule itself when it ran - I probably just did not save it right... I'll see what it does tomorrow now that I have double checked that my daily schedule is only for one plan - perhaps it got confused because some other plans are on the weekly schedule?)

Basically what I am trying to achieve is three levels of backup service:
Plan 1) Monthly full
Plan 2) Weekly Full
Plan 3) Weekly Full & Daily Incremental

Submitted by IssueBot on Thu, 10/11/2018 - 20:07

Status: Fixed ยป Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.