multiple php version switch with php-fpm

Hi, I installed php7.2 version and has 7.0 that came with virtualmin as default. I couldnt find switch from php7.0 to 7.2 when using php-fpm as PHP script execution mode. Is there any documentation about this?

Status: 
Fixed (pending)

Comments

Howdy -- unfortunately, due to the nature of how PHP-FPM works, it's not possible to switch between multiple PHP versions. You'd need to be using CGI/FCGID for that.

It looks like you're using Virtualmin GPL there though... if you're using Virtualmin GPL, and you had any followup questions, you'd want to use the Forums for support.

We monitor the Forums, along with lots of wonderful folks in the community. Thanks!

In theory we might support this in future, but right now only one FPM version can be selected.

+1 for multiple php versions for fpm

@andreychek you are wrong. It is perfeclty possible to run multiple php-fpm versions on different ports/sockets, like one for each virtual server. (i thinks its already done the way that there is a fpm pool per virtual server, there is just no version switch, but i need to check).

This is the #1 feature for me, the only thing i am missing when coming from Plesk. In Plesk you can switch versions on per-domain (virtual server) basis, which is totally sufficient for most projects. Different FPM-Versions per Directory is a feature that i would'nt miss (while i also think that this is possible with php-fpm!).

Yes, multiple FPM versions is technically possible with the right configs - we just have to implement it in Virtualmin.

I would be very grateful if you could add this feature.

It's on our TODO list.

+1 on this. Glad to hear its on the todo!

Is PHP Switching through Virtualmin possible now, how soon can we get this feature.

I have tried FCGID but it does not reflect version I changed, do I need to do anything else before and after changing PHP version.

Multiple versions are still only supported in CGI and fCGId modes.

Hello,

I need to run php7.2, but I cannot make it work ;-( Is it possible? If yes what's the best way?

Thanks in advance.

We'd be happy to talk about PHP 7.2! Though that's a different issue than the posts above. Could you open a separate request for that? Then we won't get the topics here too mixed up. Thanks!

The Problem is that virtualmin sticks to one PHP Version for FPM. If you install i.e. PHP 7.2 in addition to 7.0 you are not able to select it for PHP-FPM. This can be worked around by uninstalling all other PHP-FPM variants (cgi and others can remain). If PHP 7.2 is the only PHP-FPM version left installed, it will be selected. A virtualmin Configuration check/rescan could be required.

Right, multiple FPM version support is still in the works.

If I have only php72 from remi installed, I can't select FPM mode: Failed to save website options : No PHP versions found for mode fpm FPM pool is running ok.

Only one php version in fpm should work. Even the remi one.

If you have somewhere config another in the fpm mode then no, that is virtualmin for the moment not supporting. No matter wich repo is used. UH normally you don;t have only one remi php , you still ( should) have the default virtualmin php's somewhere i think, while wiping them virtualmin php's completly wasn't working before.

You have to configure set first the default php version for the virtual server. Only after that you can switch / set for that virtualserver and php version to the fpm mode.

Don;t know by head were these 2 parts are in the panel, but at 2 diferent places , i have to search myself each time before i can set fpm, to have the php version set right at another places in the panel. ( so first select the php version , then go to the other place where you can choose the fpm mode.)

Yes, I have only one version - 7.2. Default 5.4 and 7.0 was removed. There is new install, only removed all php and installed new one. There is no any debug log from save_phpmode.cgi?mode=fpm , so I don't know what error inside.

virtualmin check-config
The following PHP versions are available : 7.2.10 (/bin/php72-cgi), 7.2 (mod_php)
PHP-FPM support is available on this system.
PHP versions have changed to 7.2, 7.2 since last check. Regenerating any missing php.ini files.

ps aux | grep fpm
root      1069  0.0  0.0 476968 14032 ?        Ss   14:59   0:00 php-fpm: master process (/etc/opt/remi/php72/php-fpm.conf)
apache    1070  0.0  0.0 476968  7000 ?        S    14:59   0:00 php-fpm: pool www
apache    1071  0.0  0.0 476968  7000 ?        S    14:59   0:00 php-fpm: pool www
apache    1072  0.0  0.0 476968  7000 ?        S    14:59   0:00 php-fpm: pool www
apache    1073  0.0  0.0 476968  7000 ?        S    14:59   0:00 php-fpm: pool www
apache    1074  0.0  0.0 476968  7004 ?        S    14:59   0:00 php-fpm: pool www

cat /etc/opt/remi/php72/php-fpm.d/www.conf
listen = 127.0.0.1:9000

Also there is no listen = /var/run/php-fpm.sock

Sure, one PHP version should work. Did you already open a separate bug for this?

Running Centos6, I have multiple php versions installed including php-fpm for php7.2 only. Selecting FPM as execution mode forces the php version to go to 5.3 which is obviously not ideal. Even changing the default PHP version to 7.12 makes no difference.

The real issue here is that Joomla is aggressively pushing a Php7.x min for the soon to be released versions and running 7.12 without FPM (for me at least) is unusable due to mem allocation erros such as this: https://www.virtualmin.com/node/36588).

In short... +1 for FMP support for multiple php setups.

Hi guys,

is there any ETA for that functionality?

thanks

It's on the todo list for the future, though we unfortunately don't have an ETA at the moment.

In the meantime you can select different PHP versions using FCGID/CGI.

Yes I know for selecting diff version via FCGID/CGI mode but fpm..

is there a way to do it manualy, or by cli? I'd tried something like this:

mv /etc/php/7.0/fpm/pool.d/1*.conf /etc/php/7.2/fpm/pool.d

systemctl -a restart php7.0-fpm && systemctl -a restart php7.2-fpm

and for now it works, but I have a filling that I'm missing something ..

Status:
Active
»
Fixed (pending)

Ok, after much work support for running multiple PHP-FPM versions and being able to select a version on a domain-by-domain basis has been implemented in Virtualmin. This will be included in the next release.

Great! looking forward for testing this.

This is great news! Many thanks for your work on this.

Great news,

thanks a bunch for this! Looking forward to this!

Is there any estimation regarding the release date where this is included? :)

Couple of weeks at most.

Hi,

my version is 6.06-gpl

great the mutable php-fpm has now been installed. however, this does not work in my installation. he does not recognize the other php versions.

these are all displayed as version 7.0.33. even switching between versions does not seem to work. Installed are 5.6, 7.0, 7.1, 7.2 and 7.3

If you go to System Settings -> Re-Check Configuration , what PHP-FPM versions does it report as being available?

Hi,

The following PHP-FPM versions are available on this system : 7.0.30 7.1.26 7.2.15 7.3.2 7.3.2 5.6.39 5.6.39

@fbeckma how did you get 6.06 version? I'm on 6.05 and no updates to newer version? thx

Status:
Fixed (pending)
»
Needs review

Virtualmin 6.0.6 When I re-check the config I get:

The following PHP versions are available : 7.0.33 (/usr/bin/php-cgi7.0), 7.1.26 (/usr/bin/php-cgi7.1), 7.2.15 (/usr/bin/php-cgi7.2) The following PHP-FPM versions are available on this system : 7.0

Of course the other FPM versions are installed too.

I have almost the same message saying:

The following PHP versions are available : 7.0.33 (/usr/bin/php-cgi7.0), 7.2.15 (/usr/bin/php-cgi7.2) The following PHP-FPM versions are available on this system : 7.0

but systemctl status php7.2-fpm & systemctl status php7.0-fpm report FPM is enabled and active.

I have feeling virtualmin is not detecting fpm versions on system correctly?

I can second that - same here - two versions detected for cgi - one for fpm

So, I think I figured out why this detection issue is happening while troubleshooting this for our local (Debian) server.

There's a section of code in php-lib.pl that starts the detection of php-fpm versions by package name (currently this starts at line 1709):

foreach my $pname ("php-fpm", "php5-fpm", "php7-fpm",
    (map { my $v=$_; $v =~ s/\.//g;
            ("php${v}-php-fpm", "php${v}-fpm", "rh-php${v}-php-fpm") }
        @all_possible_php_versions)) {

That last variable is defined in virtual-server-lib.pl as: @all_possible_php_versions = (5, 5.2, 5.3, 5.4, 5.5, 5.6, 5.7, 5.8, 5.9,"7.0", 7.1, 7.2, 7.3);

The problem is, the "map" function in the above code means that any "dot" in the package name is stripped for the check - the code will look for a package named php72-fpm, but not php7.2-fpm. That's a huge problem for Debian, which distributes FPM using the latter naming style.

I was able to verify that I can get the config check to detect all installed versions with the code below. I have not tested further than this, and have reverted this change on my own machine. I'm putting this out there for others to review, with no guarantee it will work.

foreach my $pname ("php-fpm", "php5-fpm", "php7-fpm",
    (map { my $v=$_; $v =~ s/\.//g;
            ("php${v}-php-fpm", "php${v}-fpm", "rh-php${v}-php-fpm") }
        @all_possible_php_versions),
    (map { my $v=$_;
            ("php${v}-php-fpm", "php${v}-fpm", "rh-php${v}-php-fpm") }
        @all_possible_php_versions)) {

Note that the 5th line and 8th line of the code above differ (and it needs to be that way to parse). This basically does a check for the package versions "with dots" (5.6, 7.2, etc) after the one "without dots" (56, 72, etc).

Hopefully the maintainers can take a look a see if this is a valid solution, and something worth rolling into the production code.

Thanks for pointing this out - you're correct that a package named like php7.2-fpm won't be detected when it should be. We'll fix this in the next release.

Huge props draxius, for helping community and all users out there!

+1

I just updated php-lib.pl with the version in github, which shows a similar change (one that should be more efficient than what I wrote).

When I then run virtualmin check-config from the command line, I get the output: "The following PHP-FPM versions are available on this system : 7.0 7.0.33 7.2.15 7.3.2"

When I trigger System Settings->Re-Check Configuration through the Virtualmin portal, however, I'm still getting: "The following PHP-FPM versions are available on this system : 7.0"

I'm very confused as to why the output of these two versions of the config check would differ, but any guidance would be appreciated.

hi,

same here. "virtualmin check-config" from command line: The following PHP-FPM versions are available on this system : 5.6.39 5.6.39 5.6.39 7.0.30 on portal: The following PHP-FPM versions are available on this system : 7.0.30 7.1.26 7.2.15 7.3.2 7.3.2 5.6.39 5.6.39

portal -> Server configuration -> PHP Versions: available php versions are 5x 7.0.33 an 2x 5.6.39

I'm working with draxius on the same server. The command line / webUI disconnect was just a restart of miniserv to fix.

However, with the replacement of the one file (php-lib.pl) from the new checked-in version on github, we can try and flip sites to other versions of PHP-FPM. I see 7.0, 7.2, and 7.3 in the dropdown, I take a test site and flip it to 7.3. Looking in /etc/php/7.3/fpm/pool.d I see... nothing. I try 7.2, nothing. I drop a phpinfo.php in to the document root and nothing I do actually changes which PHP version it's using. So the dropdown is implemented, but it's not actually doing anything under the covers other than saving the php_fpm_version in the appropriate file in /etc/webmin/virtual-server/domains.

It appears that the problem we've been seeing (even after fixing the above issue with restarting the webmin miniserv - which is also required after the fix below) is based on how the version numbers are being parsed in the "Config directory for per-domain pool files" section of list_php_fpm_configs (this is also in php-lib.pl).

The function, as written, currently returns the first entry of @verdirs, rather than matching. The reason for this is because of the strings it is trying to match on: 'version' (7.2.15) and 'pkgversion' (72), ignoring 'shortversion' (7.2). Our Debian system consistently uses the format /etc/php/${shortversion}/fpm/pool.d for the pool directories, rather than the other two formats.

Below is the change-set I used to fix this:

--- php-lib.pl_pre-fix       2019-02-18 21:26:08.618385355 -0500
+++ php-lib.pl  2019-02-19 17:25:53.878412062 -0500
@@ -1754,7 +1754,8 @@
                next;
                }
        my ($bestdir) = grep { /\Q$rv->{'version'}\E/ ||
-                              /\Q$rv->{'pkgversion'}\E/ } @verdirs;
+                              /\Q$rv->{'pkgversion'}\E/ ||
+                              /\Q$rv->{'shortversion'}\E/ } @verdirs;
        $bestdir ||= $verdirs[0];
        $rv->{'dir'} = $bestdir;

IMPORTANT NOTE before trying to implement this change, you will need to revert any/all virtual hosts back to their original php-fpm versions, especially if you have 3+ versions on your system. If you don't, you will have an open port from your original version, which will prevent the newer version's master process from spawning at all.

As with the last time, I'm not guaranteeing this patch will work for you. I'll simply pointing out the quick fix we made on our end to get this un-jammed. YMMV.

here the pool config is indeed pushed into the correct version but it comes to an error:

"[20-Feb-2019 09:17:52] ERROR: unable to bind socket for address '8002': Address already in use (98) [20-Feb-2019 09:17:52] ERROR: FPM initialization failed "

Here also directly the question if you could not switch to socket. and also directly for all php versions the config is created, thus one can jump in the web between the php versions.

also here are still or again only the php versions "The following PHP-FPM versions are available on this system: 5.6.39 5.6.39 5.6.39 7.0.30" displayed.

that's me but a few 5.6er too much :)

System debian 9.7 php-fpm: 5.6, 7.0 7.1 7.2 7.3 config: /etc//fpm/pool.d/ 7.1-x.3 are optional packages binery are located in / opt / php- /

fbeckma,

I think you're running into two issues.

1) I suspect you applied the changes to the 6.06 release version of php-lib.pl, rather than an already updated version that incorporated the first fix. Here's a patch for the combined changes if you need it:

--- php-lib.pl.6.06.dist  2019-02-18 19:43:20.317226557 -0500
+++ php-lib.pl  2019-02-19 17:25:53.878412062 -0500
@@ -1707,8 +1707,9 @@
&foreign_require("software");
my @rv;
foreach my $pname ("php-fpm", "php5-fpm", "php7-fpm",
-                  (map { my $v=$_; $v =~ s/\.//g;
-                         ("php${v}-php-fpm", "php${v}-fpm", "rh-php${v}-php-fpm") }
+                  (map { my $v = $_; $v =~ s/\.//g;
+                         ("php$v-php-fpm", "php$v-fpm",
+                          "rh-php$v-php-fpm", "php$_-fpm") }
                        @all_possible_php_versions)) {
        my @pinfo = &software::package_info($pname);
        next if (!@pinfo || !$pinfo[0]);
@@ -1753,7 +1754,8 @@
                next;
                }
        my ($bestdir) = grep { /\Q$rv->{'version'}\E/ ||
-                              /\Q$rv->{'pkgversion'}\E/ } @verdirs;
+                              /\Q$rv->{'pkgversion'}\E/ ||
+                              /\Q$rv->{'shortversion'}\E/ } @verdirs;
        $bestdir ||= $verdirs[0];
        $rv->{'dir'} = $bestdir;

2) The "address already in use" error you are receiving is because the original pool configuration file (from before you made the code change) is probably still sitting in the old pool location. What we experienced (before this latest fix) was after we tried to move a site from 7.0->7.2, the 7.0 and 7.2 FPM master processes restarted. When we tried to move from 7.2 to 7.3, the 7.2 and 7.3 processes restarted. And so on.

The problem was, the pool file was not being written to the 7.2 or 7.3 directories until I changed the code (as per my prior post). Once I did, the 7.0 file was still left behind, because we kept trying to flip between 7.2 and 7.3 to prevent constant restarts on the (production) 7.0 pools. So when 7.2 restarted, we got the same "address already in use" error that you're seeing.

What you need to do to fix that is to find the old pool file that got left behind while you were trying to fix it, delete that file (or move it out of the way), and then restart the old php-fpm master daemon (in our case, this was php7.0-fpm). After that, you can try restarting the process that failed to run (the one you tried to move that virtual site to).

I still can't get it to work. Base version 6.0.6. I replaced the full php-lib.pl from github (https://github.com/virtualmin/virtualmin-gpl/blob/master/php-lib.pl) and then I applied the changes suggested by draxius

-                              /\Q$rv->{'pkgversion'}\E/ } @verdirs;
+                              /\Q$rv->{'pkgversion'}\E/ ||
+                              /\Q$rv->{'shortversion'}\E/ } @verdirs;)

But on CLI:

The following PHP versions are available : 7.0.33 (/usr/bin/php-cgi7.0), 7.1.26 (/usr/bin/php-cgi7.1), 7.2.15 (/usr/bin/php-cgi7.2)
The following PHP-FPM versions are available on this system : 7.0

And over the UI recheck-config:

The following PHP versions are available : 7.0.33 (/usr/bin/php-cgi7.0), 7.1.26 (/usr/bin/php-cgi7.1), 7.2.15 (/usr/bin/php-cgi7.2)
The following PHP-FPM versions are available on this system : 7.0

I can second that as @geissweb, only one version for FPM is found!

Hi,

the error "Address already in use" is fixed.

however, the list still looks the same. PHP Versions In domain displays 6x7.0.33 and 3x5.6.39 However, it is as if the versions would be moved so the conf in the pools of the respective php version.

  Manage PHP Configuration /etc/php/7.0/fpm/pool.d/15507558235986.conf (FPM format) always points to php7.0 although I have selected version 7.2 (blind).

here again the question if it is possible to switch the pools to sock and not to run on TCP. advantage less overhead and it can run multiple PHP versions per domain.

Maybe a checklist where the available versions for the web can be turned on and off.

I just tested something. unfortunately the error with the old php version still exists the previous php-fpm will not be restarted. so that the port is still occupied.

@geissweb, @kpendic As a reminder, we discovered that after replacing php-lib.pl, we had to restart webmin before the UI used the updated version. Can you restart that and then Re-Check Configuration through the UI?

@fbeckma It sounds like you're running into the problem we were earlier (which was the whole point of comment #43), but it's not clear what changes you have in place on php-lib, so I can't really provide much more info without knowing what your state is.

Thanks @draxius for helping us here!

But unfortunately I restarted webmin several times, problem persists. I can only hope that this issue has high est priority for the developers...

I get the same output for the "virtualmin check-config".

I replaced and edited the php-lib.pl in /usr/share/webmin/virtual-server/ (Debian 9) - that is the correct location right?

I downloaded the php-lib.pl from github and then executed the patch from # 43.

here the diff

diff php-lib.pl-git php-lib.pl
1757c1757,1758
</ \ Q $ rv -> {'pkgversion'} \ E /} @verdirs;
---
> / \ Q $ rv -> {'pkgversion'} \ E / ||
> / \ Q $ rv -> {'shortversion'} \ E /} @verdirs;
service webmin restart
virtualmin check-config

then I see several equal php versions.

@geissweb I'm happy to help as I have the time. This isn't a burning issue for us any more, but I'm able to squeak in a few responses here and there.

To be extremely specific, we're running webmin-virtual-server_6.06.gpl (via Debian package) on a Debian 9 server with all packages on the system up to date. The only file difference in the entire /usr/share/webmin/ tree is /usr/share/webmin/virtual-server/php-lib.pl (as detailed in comment #45).

The "list_php_fpm_configs" subroutine (starts line 1700 of php-lib.pl) is entirely dependent on which php-fpm packages you have installed on the system, and is based on the local package manager (dpkg). You should be able to list those with dpkg -l, and the desired output should include not just php-fpm as a package, but also php7.0-fpm and php7.2-fpm (at a minimum). If those packages do not exist, the version checker won't find the other versions.

@fbeckma Looking through the code, I'm not seeing why you'd have an issue detecting the correct php-fpm versions on the system. It definitely looks like you've got both code changes in place.

Let me know if you're still having issues with the socket/port side of things - I can walk you through what I did to get that fully resolved (it was a bit of a pain for me at first). We can at least get you back to a pristine state.

Thanks again @draxius, I've got it working now. I applied your complete patch on a 6.0.6 fresh version:

The following PHP-FPM versions are available on this system : 7.0 7.0.33 7.1.26 7.2.15 :)

The only problem now is that the config edit links are still referencing the old 7.0 version like /etc/php/7.0/fpm/pool.d/154695539811782.conf, but I can edit it manually in the /7.2/ folder.

We had that same problem at first @geissweb - this is what led to our initial "Address already in use" issue.

You want to make sure that 154695539811782.conf (to use your example) doesn't exist in both the 7.0 and 7.2 folders, otherwise you'll get the port conflict.

One approach you can take is edit the site that "should be" 7.2, but is displaying in 7.0 - if you set the site's PHP-FPM Version back to 7.0, you'll functionally re-sync reality with what Virtualmin things is going on. Then you can move the site back to 7.2 and it should work.

If you have moved more than one site already, this gets a little trickier - you'll want to revert all of them back to the pre-patch version (which I presume is 7.0.33) first before you reset any of them to 7.2. Any other setting customizations you've made should stay in place, so you shouldn't have to worry about that, but you obviously want to get back to a state where you can seamlessly slide between PHP versions without concern.

@draxius Yes, the conf is in the correct folder on the server. I had the sites running on fpm-7.0 before I did anything, it works well. I just mean the link to edit the fpm-conf in the virtualmin UI still points to the 7.0 folder, although the conf was placed correctly in the 7.2 folder. I hope that it will be addressed in the official release.

@fbeckma Don't use the latest github version. Just take a vanilla 6.0.6 php-lib.pl and apply the patch as stated in comment #45. Set your domains to use 7.0-fpm before you recheck the config.

Hi,

I have loaded the github php-lib.pl 6.0.6 and applied the patch from # 45.

unfortunately still the same result. Manage PHP Configuration /etc/php5/fpm/pool.d/155083067221739.conf (FPM format) here is the file to lie, but is in /etc/php/7.0/fpm/pool.d/

The following PHP-FPM versions are available on this system: 5.6.39 5.6.39 5.6.39 7.0.33

@draxius I would be interested in the config for socket

@fbmecka, it looks like the UI has (yet another) bug, as pointed out by @geissweb's last post. The test sites we've moved to 7.2 and 7.3 still show /etc/php/7.0/fpm/pool.d/ as the file path, and editing the config file manually through the UI no longer works on those sites.

To validate which config is really in use, just look for these two files: /etc/php5/fpm/pool.d/155083067221739.conf /etc/php/7.0/fpm/pool.d/155083067221739.conf

If only one exists, and your site is served properly, then then the patch I recommended handles getting things working generally, but I haven't even started looking at a solution for the "Manage PHP Configuration" page as of yet.

Found it!

In feature-web.pl (should be in the same folder as php-lib.pl Change line 2337 from:

my $conf = &get_php_fpm_config();

to:

my $conf = &get_php_fpm_config($d);

The current line returns the "default" fpm config, and the modified line returns the config for the virtual server you're configuring.

This is the function used to build the "PHP-FPM Configuration" link on the menu, which is why it gets all out of whack.

After editing this file, you must: 1) Restart the webmin miniserv (service webmin restart on Debian) 2) "Re-check configuration" through the UI again.

After that, the links should show up properly. Ideally, this will close the loop on this problem, but once again, no guarantees.

Thanks so much @draxius :)

Thanks for pointing out this bug in feature-web.pl - it will be fixed in the next release.

Unfortunately I think there is still work to do. I have got the update to 6.0.6-gpl2 on Debian9 on another server and with that version I even don't see FPM as option to run PHP on in the settings.

I only see mod_php (which is completely uninstalled on the server) and the cgi/fcgi options. Check config shows:

Die folgenden PHP Versionen sind verfügbar : 7.0.33 (/usr/bin/php-cgi7.0), 7.1.26 (/usr/bin/php-cgi7.1), 7.2.15 (/usr/bin/php-cgi7.2), 7.3.2 (/usr/bin/php-cgi7.3), 7.0 (mod_php)

The following PHP-FPM versions are available on this system : 7.0 7.0.33 7.1.26 7.2.15 7.3.2

UPDATE:

I was able to get the FPM selection back after I changed the corresponding /etc/webmin/virtual-server/domains/.conf, from: php_fpm_version=5 to php_fpm_version=7.2

@geissweb I downloaded and extracted the files in gpl2, and it looks like this is a release to address other issues, not the PHP ones we've been discussing. GitHub still isn't caught up with all of the fixes above, and it looks like the new Debian package was released prior to that check-in.

@JamieCameron As we were discussing starting at comment #43, the file path detection for pool configurations seems to suffer from a similar "bug"(?) on Debian, where it cannot find the correct /etc/php/7.x/fpm/pool.d path. Below is a patch against that file that fixes this particular problem - this has been tested by several of us already, so it seems to work. Without this change, it looks for paths like /etc/php/7.0.33/ and /etc/php/70, but not /etc/php/7.0 (which is the path structure that Debian uses). Given the stream of text, I'm sure it was pretty easy to miss, though.

--- php-lib.pl  2019-02-25 11:09:32.075630937 -0500
+++ /usr/share/webmin/virtual-server/php-lib.pl 2019-02-25 11:10:11.591103045 -0500
@@ -1754,7 +1754,8 @@
                next;
                }
        my ($bestdir) = grep { /\Q$rv->{'version'}\E/ ||
-                              /\Q$rv->{'pkgversion'}\E/ } @verdirs;
+                              /\Q$rv->{'pkgversion'}\E/ ||
+                              /\Q$rv->{'shortversion'}\E/ } @verdirs;
        $bestdir ||= $verdirs[0];
        $rv->{'dir'} = $bestdir;

We're holding off on patching to the latest Debian package until all the pieces of this are sorted out (we have a working code-base right now, so there's no real rush on our end). To clarify our current state (which works fully), we are running:

  • Fully patched Debian 9.8 system as of yesterday
  • webmin-virtual-server package is webmin-virtual-server_6.06.gpl_all.deb
  • php-lib.pl was updated to match version currently in GitHub (commit e1987a2), and then patched as detailed in the code block above
  • feature-web.pl was updated to match version currently in GitHub (commit 9feb9dd)

If there's any other information I can provide, please let me know.

Status:
Needs review
»
Active

When will the official fix be out as my machine is messed as well due to this.

Not true on the fpm package.

I have php7.2-fpm installed and when running the VM PRO check I get this....

No PHP-FPM packages were found on this system.

# apt-get install --reinstall php7.2-fpm
Reading package lists... Done
Building dependency tree      
Reading state information... Done
0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 0 not upgraded.
Need to get 1,395 kB of archives.
After this operation, 0 B of additional disk space will be used.
Get:1 https://packages.sury.org/php stretch/main amd64 php7.2-fpm amd64 7.2.16-1+0~20190307202415.17+stretch~1.gbpa7be82 [1,395 kB]
Fetched 1,395 kB in 1s (1,330 kB/s) 
(Reading database ... 343799 files and directories currently installed.)
Preparing to unpack .../php7.2-fpm_7.2.16-1+0~20190307202415.17+stretch~1.gbpa7be82_amd64.deb ...
Unpacking php7.2-fpm (7.2.16-1+0~20190307202415.17+stretch~1.gbpa7be82) over (7.2.16-1+0~20190307202415.17+stretch~1.gbpa7be82) ...
Setting up php7.2-fpm (7.2.16-1+0~20190307202415.17+stretch~1.gbpa7be82) ...
NOTICE: Not enabling PHP 7.2 FPM by default.
NOTICE: To enable PHP 7.2 FPM in Apache2 do:
NOTICE: a2enmod proxy_fcgi setenvif
NOTICE: a2enconf php7.2-fpm
NOTICE: You are seeing this message because you have apache2 package installed.
Processing triggers for systemd (232-25+deb9u9) ...
Processing triggers for man-db (2.7.6.1-2) ...
[root@desktop ~]
# a2enmod proxy_fcgi setenvif
Considering dependency proxy for proxy_fcgi:
Module proxy already enabled
Module proxy_fcgi already enabled
Module setenvif already enabled
[root@desktop ~]
# a2enconf php7.2-fpm
Conf php7.2-fpm already enabled

hello @draxius , in your comment https://www.virtualmin.com/comment/809098#comment-809098

im struggling to make that work. I can change php versions, but the php-fpm will not change to the new version . So i check on my php7.0 pool.d directory and the files are there and never created in the new version of php (in this case php7.1)

your help is appreciated

Any news on this? I am facing the same problem on my server

@aschenbr - The changes I made in the referenced comment modified the version of php-lib.pl found here: https://github.com/virtualmin/virtualmin-gpl/blob/e1987a29dd4c88343ea5e6...

You'll also need the updated feature-web.pl - https://github.com/virtualmin/virtualmin-gpl/blob/9feb9dded0da06b0b186ce...

Those files are not updated in any debian-packaged version at the moment, and each includes a necessary piece of this puzzle. From there, you will need to apply the additional change here: https://www.virtualmin.com/comment/809098#comment-809098

Hopefully that can help get you straightened out.

This still isn't working on VM Pro even with the diff added. No PHP-FPM packages were found on this system. Is what I get when re-checking configuration.

NM I forgot to add the diff for php-lib.pl

I can confirm that VM Pro works with those changes.

The following PHP versions are available : 5.6.40 (/usr/bin/php-cgi5.6), 7.0.33 (/usr/bin/php-cgi7.0), 7.1.27 (/usr/bin/php-cgi7.1), 7.2.16 (/usr/bin/php-cgi7.2), 7.3.3 (/usr/bin/php-cgi7.3), 7.0 (mod_php)

The following PHP-FPM versions are available on this system : 7.2.16

Whoops spoke to soon. Yes VM Pro finds fpm now but in Website Options you don't have the option to use FPM.

Does edit_phpmode.cgi need to be edited ?

I followed this and it worked for me @aschenbr - The changes I made in the referenced comment modified the version of php-lib.pl found here: https://github.com/virtualmin/virtualmin-gpl/blob/e1987a29dd4c88343ea5e6...

You'll also need the updated feature-web.pl - https://github.com/virtualmin/virtualmin-gpl/blob/9feb9dded0da06b0b186ce...

Those files are not updated in any debian-packaged version at the moment, and each includes a necessary piece of this puzzle. From there, you will need to apply the additional change here: https://www.virtualmin.com/comment/809098#comment-809098

Hopefully that can help get you straightened out.

I made all those changes. Maybe there is a file in the VM Pro that needs to be changed still that isn't posted yet.

Patched a few Debian 9.x boxes as specified in this thread.

Result:

The following PHP versions are available : 7.0.33 (/usr/bin/php-cgi7.0), 7.3.3 (/usr/bin/php-cgi7.3)

The following PHP-FPM versions are available on this system : 7.0 7.0.33 7.3.3

But can you select the FPM version under Website Options ?

Yes, I was able to flop from FPM or FCGI, and from PHP 7.0.x or 7.3.x

Patched and fix also on debian 9.8! YAY!

Just a short note if cli shows the version but web does not:

Restart your webmin server

I missed that :(

One more debian 9 system got multi php-fpm. thanks! By the way. how to make fsgi + php fpm. As people write that's the most performance solution now

borekon's picture
Submitted by borekon on Wed, 05/15/2019 - 10:54

Hi, I think i did something wrong. I replaced files php-lib and feature-web and can change between php versions, but the config file is not switched. I back to the original php version and all the config in php config disapeared.... Should i install virtualmin from scratch?

the only change that i needed to make on the latest updates in debian and virtualmin was to edit the one file php-lib.pl as outlined by https://www.virtualmin.com/comment/808744#comment-808744

after doing that then reckecking configuration in Virtualmin, I am now able to select different releases of fpm (ie 7.0-7.3).

I did notice that virtualmin authentic theme has thrown an error after doing this...(the error dissapeared before i could copy it), so I am not sure if that is related to this php fpm change or not?

Any update on 6.07 availablity?